-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Basic auth key encoding #446
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
===========================================
- Coverage 78.32% 65.96% -12.37%
===========================================
Files 61 58 -3
Lines 5039 4933 -106
===========================================
- Hits 3947 3254 -693
- Misses 882 1412 +530
- Partials 210 267 +57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@mariomac: I am looking at 401 Unauthorized errors in the latest release code [Beyla v1.2.1], am I missing anything? ERROR: Grafana Beyla version used
|
@NiranjanHD please check that, in the Grafana cloud API key, you are copying the raw API key and not the generated OTEL Headers ("Authorization: Basic ...."). As an alternative, try using the OTEL_EXPORTER_OTLP_HEADERS, as stated in the steps here: |
* Fix Basic auth key encoding * Fix linting
Fixes: #442
We weren't closing the encoder and sometimes we missed some bytes in the API key 😱